DM-33303: Allow DatasetType to differ to registry on get/put #635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
2 tasks
This is mainly needed for the new tests in ctrl_mpexec but can serve as an example of what is possible.
If an explicit DatasetType was given rather than a name then previously this was an error. Now, if they are compatible it will succeed. Furthermore, on get the python type associated with the user-supplied DatasetType will be returned.
These tests involve an explicit DatasetType in get/put.
can_convert should return False if one of the storage classes can't be imported. This was tickled by one of the tests using the Config storage class.
timj
force-pushed
the
tickets/DM-33303
branch
from
d91c7a7
to
3a29dad
Compare
Codecov Report
@@ Coverage Diff @@
## main #635 +/- ##
=======================================
Coverage 84.12% 84.13%
=======================================
Files 237 237
Lines 30185 30214 +29
Branches 5018 5022 +4
=======================================
+ Hits 25394 25421 +27
- Misses 3646 3648 +2
Partials 1145 1145
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the DatasetTypes are compatible with each other.
Checklist
doc/changes