Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-34105: Clean up dependencies #175

Merged
merged 9 commits into from Mar 23, 2022
Merged

DM-34105: Clean up dependencies #175

merged 9 commits into from Mar 23, 2022

Conversation

timj
Copy link
Member

@timj timj commented Mar 21, 2022

  • Use pipe_base for Instrument
  • Remove afw from test and examples.

Requires lsst/pipe_base#239

Checklist

  • ran Jenkins
  • added a release note for user-visible changes to doc/changes

A core implementation can now be obtained from pipe_base rather
than obs_base.
The examples are examples and don't really need to use
ExposureF
Only relevant if lsst.base is available.
@codecov
Copy link

codecov bot commented Mar 22, 2022

Codecov Report

❗ No coverage uploaded for pull request base (main@768b03a). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #175   +/-   ##
=======================================
  Coverage        ?   81.37%           
=======================================
  Files           ?       41           
  Lines           ?     3297           
  Branches        ?      550           
=======================================
  Hits            ?     2683           
  Misses          ?      455           
  Partials        ?      159           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 768b03a...c762a38. Read the comment docs.

It is not exported by default by pex_config and the tests
have been relying on it being imported by the gen2
code in pipe_base (argumentParser.py).
@timj timj merged commit 8174bdb into main Mar 23, 2022
@timj timj deleted the tickets/DM-34105 branch March 23, 2022 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants