DM-34105: Move some generic code from obs_base #239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Black makes them irrelevant.
timj
force-pushed
the
tickets/DM-34105
branch
2 times, most recently
from
9737322
to
cbae4b2
Compare
This was referenced Mar 22, 2022
Merged
Merged
Merged
Codecov Report
@@ Coverage Diff @@
## main #239 +/- ##
==========================================
+ Coverage 71.55% 72.17% +0.62%
==========================================
Files 48 60 +12
Lines 6313 6595 +282
Branches 1216 1244 +28
==========================================
+ Hits 4517 4760 +243
- Misses 1574 1606 +32
- Partials 222 229 +7
Continue to review full report at Codecov.
|
timj
force-pushed
the
tickets/DM-34105
branch
3 times, most recently
from
0f4e6c8
to
137e070
Compare
andy-slac
approved these changes
Mar 23, 2022
This is the obs_base Instrument class with the afw dependencies and the curated calibrations removed. The curated calibrations core functionality may well come back but needs some thought.
No longer need to fake one since the class does exist now in pipe_base.
This includes setting up of some click infrastructure since this is the first click command in pipe_base
There seems to be a strange interaction with the click command line test messing with the logger if called before this test and it doesn't hurt to be more specific.
Packages has moved from base to utils and can now be assumed to always be available.
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
obs_base is going to be hard to disentangle from afw, ip_isr, and pipe_tasks. Move a subset of Instrument class to pipe_base along with support material.
Checklist
doc/changes