DM-36360: Improve diagnostic visibility for empty QGs. #204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TallJimbo
force-pushed
the
tickets/DM-36360
branch
4 times, most recently
from
cc8b79f
to
ffcda23
Compare
parejkoj
approved these changes
Sep 29, 2022
| @@ -137,7 +137,8 @@ def qgraph(ctx: click.Context, **kwargs: Any) -> None: | |||
| file=sys.stderr, | |||
| ) | |||
| return | |||
| script.qgraph(pipelineObj=pipeline, **kwargs, show=show) | |||
| if script.qgraph(pipelineObj=pipeline, **kwargs, show=show) is None: | |||
| raise click.ClickException("QuantumGraph was empty; diagnostic logging above may have details.") | |||
There was a problem hiding this comment.
Instead of "diagnostic logging above", maybe be more explicit: "look for WARNING/ERROR/CRITICAL log messages above for more details."? And similarly below.
By moving the exception raise down to the outer click layer (returning None through all higher layers) we avoid the long traceback that hides the useful information being logged by pipe_base.
The standard library type annotations now indicate that multiprocessing.get_context returns a not-very-useful object unless the 'method' argument is exactly one of three string literals, so we need to annotate accordingly to avoid mypy complaints about that fallback object.
TallJimbo
force-pushed
the
tickets/DM-36360
branch
from
ffcda23
to
8fb9b22
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By moving the exception raise down to the outer click layer (returning None through all higher layers) we avoid the long traceback that hides the useful information being logged by pipe_base.
Checklist
doc/changes(in pipe_base)I expect the
build_and_testcheck here to fail until the pipe_base is branch is merged.