Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-36360: Improve diagnostic visibility for empty QGs. #204

Merged
merged 2 commits into from
Sep 30, 2022
Merged

DM-36360: Improve diagnostic visibility for empty QGs. #204

merged 2 commits into from
Sep 30, 2022

Commits on Sep 30, 2022

  1. Improve diagnostic visibility for empty QGs. 

    By moving the exception raise down to the outer click layer (returning
None through all higher layers) we avoid the long traceback that hides
the useful information being logged by pipe_base.
    @TallJimbo
    TallJimbo committed Sep 30, 2022
    Configuration menu
    Copy the full SHA
    986d03a View commit details
    Browse the repository at this point in the history

  2. Provide more precise type annotation literal arg. 

    The standard library type annotations now indicate that
multiprocessing.get_context returns a not-very-useful object unless
the 'method' argument is exactly one of three string literals, so we
need to annotate accordingly to avoid mypy complaints about that
fallback object.
    @TallJimbo
    TallJimbo committed Sep 30, 2022
    Configuration menu
    Copy the full SHA
    8fb9b22 View commit details
    Browse the repository at this point in the history