Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-36412: Try to set the datastore cache directory explicitly #206

Merged
merged 3 commits into from Oct 7, 2022

Conversation

timj
Copy link
Member

@timj timj commented Oct 5, 2022

Checklist

Needs lsst/daf_butler#738

  • ran Jenkins
  • added a release note for user-visible changes to doc/changes

@codecov
Copy link

codecov bot commented Oct 5, 2022

Codecov Report

Base: 83.36% // Head: 83.38% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (7b0a5f2) compared to base (5035d90).
Patch coverage: 92.30% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #206      +/-   ##
==========================================
+ Coverage   83.36%   83.38%   +0.01%     
==========================================
  Files          48       48              
  Lines        3860     3870      +10     
  Branches      588      589       +1     
==========================================
+ Hits         3218     3227       +9     
- Misses        472      473       +1     
  Partials      170      170              
Impacted Files Coverage Δ
python/lsst/ctrl/mpexec/cmdLineFwk.py 68.40% <90.90%> (+0.77%) ⬆️
tests/test_cmdLineFwk.py 97.96% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@timj timj force-pushed the tickets/DM-36412 branch 2 times, most recently from 40a0849 to e080dfa Compare October 5, 2022 21:30
Copy link
Collaborator

@andy-slac andy-slac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

python/lsst/ctrl/mpexec/cmdLineFwk.py Outdated Show resolved Hide resolved
python/lsst/ctrl/mpexec/cmdLineFwk.py Outdated Show resolved Hide resolved
We have to do it early to ensure that in fork mode the
cache is defined before the initial output Butler is created
(fork will not pickle it).

Spawn will create a new pickled butler that will inherit the environment
and in that scenario the setting of the environment variable
can reliably happen in MPGraphExecutor.
@timj timj marked this pull request as ready for review October 6, 2022 21:16
@timj timj merged commit 52ca013 into main Oct 7, 2022
@timj timj deleted the tickets/DM-36412 branch October 7, 2022 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants