DM-36412: Add new env var DAF_BUTLER_CACHE_DIRECTORY_IF_UNSET #738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 84.79% // Head: 84.80% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #738 +/- ##
==========================================
+ Coverage 84.79% 84.80% +0.01%
==========================================
Files 254 254
Lines 32911 32967 +56
Branches 5618 5630 +12
==========================================
+ Hits 27907 27959 +52
- Misses 3783 3785 +2
- Partials 1221 1223 +2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
2 tasks
andy-slac
approved these changes
Oct 6, 2022
This only overrides the cache directory if nothing has set it explicitly from config or the other env var.
If multiple processes are sharing a cache directory and caching on read then it is possible that the other process has already copied the dataset into the cache. We therefore need to check before we try to copy it.
…able Also change the behavior such that if that variable gets set after the cache manager has been instantiated, it will still use that environment variable to make the default cache directory if it has not yet been defined.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This only overrides the cache directory if nothing has set it explicitly from config or the other env var.
Checklist
doc/changes