Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-37450: Fix text with faulty expectations. #215

Merged
merged 2 commits into from Jan 3, 2023
Merged

Conversation

TallJimbo
Copy link
Member

@TallJimbo TallJimbo commented Jan 3, 2023

New butler code causes the storage class in the DatasetType passed to findDataset to be respected, which causes the storage class in the input connection to be respected.

Relies on lsst/daf_butler#766

Checklist

  • ran Jenkins
  • added a release note for user-visible changes to doc/changes

New butler code causes the storage class in the DatasetType passed
to findDataset to be respected, which causes the storage class in the
input connection to be respected.
@codecov
Copy link

codecov bot commented Jan 3, 2023

Codecov Report

Base: 83.43% // Head: 83.43% // No change to project coverage 👍

Coverage data is based on head (bb1eb2f) compared to base (f60f162).
Patch coverage: 100.00% of modified lines in pull request are covered.

❗ Current head bb1eb2f differs from pull request most recent head c7619af. Consider uploading reports for the commit c7619af to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #215   +/-   ##
=======================================
  Coverage   83.43%   83.43%           
=======================================
  Files          48       48           
  Lines        3888     3888           
  Branches      592      592           
=======================================
  Hits         3244     3244           
  Misses        473      473           
  Partials      171      171           
Impacted Files Coverage Δ
python/lsst/ctrl/mpexec/cli/utils.py 90.00% <100.00%> (ø)
tests/test_simple_pipeline_executor.py 95.17% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@timj timj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks okay. Seems as if there are a couple of mypy fixes needed from my additions to daf_butler before Christmas.

@TallJimbo
Copy link
Member Author

I was worried I'd have to wade back into the types-click problem to deal with those annotations, but happily they were all on our end (one commit here and one in daf_butler).

@TallJimbo TallJimbo merged commit 916d637 into main Jan 3, 2023
@TallJimbo TallJimbo deleted the tickets/DM-37450 branch January 3, 2023 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants