New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DM-37450: Make Registry.findDataset respect DatasetType's storage class. #766
Conversation
Codecov ReportBase: 85.24% // Head: 85.26% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #766 +/- ##
==========================================
+ Coverage 85.24% 85.26% +0.01%
==========================================
Files 261 261
Lines 34599 34630 +31
Branches 5851 5854 +3
==========================================
+ Hits 29495 29526 +31
Misses 3861 3861
Partials 1243 1243
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
adc17dc
to
255c16d
Compare
doc/changes/DM-37450.bugfix.md
Outdated
@@ -0,0 +1,2 @@ | |||
Make `Registry.findDataset` respect the storage class of a `DatasetRef` that is passed to it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you mean DatasetType here.
Allowing None here is consistent with docs and usage in ctrl_mpexec.
032cd2b
to
eef557e
Compare
Checklist
doc/changes