Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-37450: Make Registry.findDataset respect DatasetType's storage class. #766

Merged
merged 5 commits into from Jan 3, 2023

Conversation

TallJimbo
Copy link
Member

@TallJimbo TallJimbo commented Jan 3, 2023

Checklist

  • ran Jenkins
  • added a release note for user-visible changes to doc/changes

@codecov
Copy link

codecov bot commented Jan 3, 2023

Codecov Report

Base: 85.24% // Head: 85.26% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (eef557e) compared to base (4bcfb78).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #766      +/-   ##
==========================================
+ Coverage   85.24%   85.26%   +0.01%     
==========================================
  Files         261      261              
  Lines       34599    34630      +31     
  Branches     5851     5854       +3     
==========================================
+ Hits        29495    29526      +31     
  Misses       3861     3861              
  Partials     1243     1243              
Impacted Files Coverage Δ
python/lsst/daf/butler/cli/utils.py 93.48% <ø> (ø)
python/lsst/daf/butler/core/datasets/type.py 85.96% <100.00%> (+0.12%) ⬆️
python/lsst/daf/butler/registries/sql.py 81.87% <100.00%> (+0.12%) ⬆️
.../butler/registry/datasets/byDimensions/_storage.py 77.34% <100.00%> (+0.22%) ⬆️
...n/lsst/daf/butler/registry/interfaces/_datasets.py 76.31% <100.00%> (ø)
python/lsst/daf/butler/registry/tests/_registry.py 98.80% <100.00%> (+0.02%) ⬆️
python/lsst/daf/butler/_butler.py 79.18% <0.00%> (-0.30%) ⬇️
python/lsst/daf/butler/core/storageClass.py 94.49% <0.00%> (+0.55%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@@ -0,0 +1,2 @@
Make `Registry.findDataset` respect the storage class of a `DatasetRef` that is passed to it.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you mean DatasetType here.

Allowing None here is consistent with docs and usage in ctrl_mpexec.
@TallJimbo TallJimbo changed the title DM-37450: Make Registry.findDataset respect DatasetRef's storage class. DM-37450: Make Registry.findDataset respect DatasetType's storage class. Jan 3, 2023
@TallJimbo TallJimbo merged commit 6688d7c into main Jan 3, 2023
@TallJimbo TallJimbo deleted the tickets/DM-37450 branch January 3, 2023 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants