Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-37703: Catch unresolved refs warnings and some workarounds #232

Merged
merged 3 commits into from Apr 19, 2023

Conversation

timj
Copy link
Member

@timj timj commented Apr 14, 2023

Relies on lsst/daf_butler#821

Checklist

  • ran Jenkins
  • added a release note for user-visible changes to doc/changes

@codecov
Copy link

codecov bot commented Apr 14, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.21 ⚠️

Comparison is base (bb2d212) 83.80% compared to head (c4a59f1) 83.60%.

❗ Current head c4a59f1 differs from pull request most recent head e3c9915. Consider uploading reports for the commit e3c9915 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #232      +/-   ##
==========================================
- Coverage   83.80%   83.60%   -0.21%     
==========================================
  Files          48       48              
  Lines        4527     4538      +11     
  Branches      814      819       +5     
==========================================
  Hits         3794     3794              
- Misses        547      557      +10     
- Partials      186      187       +1     
Impacted Files Coverage Δ
tests/test_cmdLineFwk.py 97.58% <ø> (ø)
python/lsst/ctrl/mpexec/mock_task.py 86.81% <100.00%> (+0.60%) ⬆️
python/lsst/ctrl/mpexec/mpGraphExecutor.py 87.13% <100.00%> (+0.16%) ⬆️
python/lsst/ctrl/mpexec/preExecInit.py 69.30% <100.00%> (-0.16%) ⬇️
python/lsst/ctrl/mpexec/singleQuantumExecutor.py 70.30% <100.00%> (+0.45%) ⬆️

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Collaborator

@andy-slac andy-slac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

python/lsst/ctrl/mpexec/mock_task.py Outdated Show resolved Hide resolved
tests/test_cmdLineFwk.py Outdated Show resolved Hide resolved
The butler get will work with the dataset type and dataId
as separate parameters.
@timj timj merged commit 3a2e5ed into main Apr 19, 2023
9 checks passed
@timj timj deleted the tickets/DM-37703 branch April 19, 2023 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants