DM-37703: Deprecate unresolved refs #821
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 14, 2023
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #821 +/- ##
=======================================
Coverage 87.76% 87.77%
=======================================
Files 268 268
Lines 34975 35007 +32
Branches 7355 7368 +13
=======================================
+ Hits 30696 30727 +31
+ Misses 3125 3122 -3
- Partials 1154 1158 +4
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
This was referenced Apr 14, 2023
andy-slac
approved these changes
Apr 18, 2023
| "Support for creating unresolved refs will soon be removed. Please contact the " | ||
| "middleware team for advice on modifying your code to use resolved refs.", | ||
| category=UnresolvedRefWarning, | ||
| stacklevel=2, # _find_outside_stacklevel(), |
There was a problem hiding this comment.
Actually, I'm supposed to remove the "2". I used the 2 for testing daf_butler so I could see whether things were coming from but failed to put it back to use the right code to find the outside level -- that explains why my ci_hsc_gen3 testing is full of reports about using ref.py and I was surprised it wasn't telling me the real calling location outside of butler.
timj
force-pushed
the
tickets/DM-37703
branch
3 times, most recently
from
6863f53
to
d94f706
Compare
They did not need to use unresolved refs so easier to fix them and get rid of the warning.
Sometimes the warnings are ignored, and in some places we use a resolved ref.
We now require UUID dataset IDs and registry no longer needs to be the source of truth. We would like to be able to create IDs as part of DatasetRef construction and circular dependencies suggest that it's easier to move the code out of registry.
We want to ensure that when butler issues an unresolved ref warning that it looks like it comes from user code and not butler internals.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Warnings do come from tests -- the test code is testing unresolved refs for a reason. I have not gone through every test to decide if something can be replaced with a resolved ref. I have changed the
DatasetRefconstructor so that it now creates an id if called with just a run.Checklist
doc/changes