New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DM-26874: rename pipetask2 to pipetask, remove old pipetask #85
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, couple of minor comments.
class _PipelineActionType: | ||
"""Class defining a callable type which converts strings into | ||
_PipelineAction instances. | ||
Parameters |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Blank line is needed before section header.
python/lsst/ctrl/mpexec/cli/utils.py
Outdated
_PipelineAction instances. | ||
Parameters | ||
---------- | ||
action : str |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Type names should be in backticks.
python/lsst/ctrl/mpexec/cli/utils.py
Outdated
|
||
def __repr__(self): | ||
"""String representation of this class. | ||
argparse can use this for some error messages, default implementation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't mention argparse any more 🙂 Blank line is needed between summary line and detailed info.
8f0bf8c
to
7f80b30
Compare
No description provided.