Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-26874: rename pipetask2 to pipetask, remove old pipetask #85

Merged
merged 4 commits into from Oct 6, 2020

Conversation

n8pease
Copy link
Contributor

@n8pease n8pease commented Oct 3, 2020

No description provided.

Copy link
Collaborator

@andy-slac andy-slac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, couple of minor comments.

class _PipelineActionType:
"""Class defining a callable type which converts strings into
_PipelineAction instances.
Parameters
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blank line is needed before section header.

_PipelineAction instances.
Parameters
----------
action : str
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Type names should be in backticks.


def __repr__(self):
"""String representation of this class.
argparse can use this for some error messages, default implementation
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't mention argparse any more 🙂 Blank line is needed between summary line and detailed info.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants