Merge pull request #686 from lsst/tickets/DM-34884

DM-34884: Disable checks of schema checksums
lsst · May 20, 2022 · 9b65f08 · 9b65f08
2 parents cdca06c + 1ecbe8d
commit 9b65f08
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 9 deletions.
diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml
@@ -8,7 +8,7 @@ repos:
       - id: end-of-file-fixer
       - id: trailing-whitespace
   - repo: https://github.com/psf/black
-    rev: 22.1.0
+    rev: 22.3.0
     hooks:
       - id: black
         # It is recommended to specify the latest version of Python

diff --git a/python/lsst/daf/butler/registry/managers.py b/python/lsst/daf/butler/registry/managers.py
@@ -44,7 +44,7 @@
     OpaqueTableStorageManager,
     StaticTablesContext,
 )
-from .versions import ButlerVersionsManager, DigestMismatchError
+from .versions import ButlerVersionsManager
 
 _Attributes = TypeVar("_Attributes")
 _Dimensions = TypeVar("_Dimensions")
@@ -202,13 +202,6 @@ def loadRepo(self, database: Database) -> RegistryManagerInstances:
         # verify that configured versions are compatible with schema
         versions.checkManagersConfig()
         versions.checkManagersVersions(database.isWriteable())
-        try:
-            versions.checkManagersDigests()
-        except DigestMismatchError as exc:
-            # potentially digest mismatch is a serious error but during
-            # development it could be benign, treat this as warning for
-            # now.
-            _LOG.warning(f"Registry schema digest mismatch: {exc}")
         # Load content from database that we try to keep in-memory.
         instances.refresh()
         return instances

diff --git a/python/lsst/daf/butler/registry/versions.py b/python/lsst/daf/butler/registry/versions.py
@@ -33,6 +33,8 @@
 import logging
 from typing import TYPE_CHECKING, Any, Mapping, MutableMapping, Optional
 
+from deprecated.sphinx import deprecated
+
 from .interfaces import VersionedExtension, VersionTuple
 
 if TYPE_CHECKING:
@@ -316,13 +318,19 @@ def checkManagersVersions(self, writeable: bool) -> None:
                         f"{storedVersion} for extension {extension.extensionName()}"
                     )
 
+    @deprecated(reason="Schema checksums are ignored", category=FutureWarning, version="v24.0")
     def checkManagersDigests(self) -> None:
         """Compare current schema digests with digests stored in database.
 
         Raises
         ------
         DigestMismatchError
             Raised if digests are not equal.
+
+        Notes
+        -----
+        This method is not used currently and will probably disappear in the
+        future as we remove schema checksums.
         """
         if self._attributesEmpty:
             return