Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-34884: Disable checks of schema checksums #686

Merged
merged 1 commit into from May 20, 2022
Merged

Conversation

andy-slac
Copy link
Contributor

The code that calculates checksums is still there, will be removed when
we are sure that we never need it.

Checklist

  • ran Jenkins
  • added a release note for user-visible changes to doc/changes

The code that calculates checksums is still there, will be removed when
we are sure that we never need it.
@codecov
Copy link

codecov bot commented May 19, 2022

Codecov Report

Merging #686 (1ecbe8d) into main (cdca06c) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #686      +/-   ##
==========================================
- Coverage   84.28%   84.27%   -0.02%     
==========================================
  Files         243      243              
  Lines       31098    31096       -2     
  Branches     5245     5245              
==========================================
- Hits        26212    26207       -5     
- Misses       3718     3724       +6     
+ Partials     1168     1165       -3     
Impacted Files Coverage Δ
python/lsst/daf/butler/registry/managers.py 94.93% <100.00%> (+2.16%) ⬆️
python/lsst/daf/butler/registry/versions.py 65.00% <100.00%> (-3.65%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cdca06c...1ecbe8d. Read the comment docs.

Copy link
Member

@timj timj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This matches what we agreed in the meeting today.

@andy-slac andy-slac merged commit 9b65f08 into main May 20, 2022
@andy-slac andy-slac deleted the tickets/DM-34884 branch May 20, 2022 02:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants