DM 21146: Add support for PostgreSQL Registry #189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Code was separated from a Draft-PR which contained both S3Datastore and PostgreSqlRegistry into a self-standing PostgreSqlRegistry code only.
- transitioned connection strings to ConnectionStringBuilder - added tests for ConnectionStringBuilder - added class attributes for desired default values of dialect and driver Removed RDSButlerTestCase. Rebased onto master.
Rebased onto master. Removed RDS tests and supporting files.
ConnectionSttring classes. Removed RegistryConfig 'cls' key from default configs. The registry class is determined through the 'db' string except in the cases when the 'cls' class is explicitly stated. This includes ignoring the cls key in registry setConfigRoot. Omit explicitly setting cls values.
Remove ConnectionStringClass. Reduce code duplication by moving the dialect and correct registry class doImport statements to Registry. Fixed tests.
Correct class resolution moved to Registry. Removed that logic from Butler.makeRepo and Registry.fromConfig. ConnectionStringFactory is now used only internaly in the Registry. Removed the connection string handling from the registry subclasses. Removed the ConnectionString classes. ConnectionStringFactory now produces an SQLAlchemy URL instances. Added checks to avoid reading username and password when not required. Fixed OracleRegistry misshandling of config keys in OracleRegistry.setConfigRoot. Changed the create_engine calls on all registry subclasses to reflect the changes. Docs.
ConnectionStringFactory.fromConfig is now a classmethod. Fixes to Registry where this makes a difference. Fix to a doc string return value. Added missing comment about import having to be in a method.
Moved the getDialect, getRegistryClass and connectionString into RegistryConfig and made them instance methods instead. Moved RegistryConfig into its own module. Circular import error is now handled in the ConnectionStringFactory instead of in multiple places in RegistryConfig. Fixes to ConnectionStringFactory (removal of useless code).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the continuation/copy of PR #161 for the purposes of Jenkins tests.
Adds PostgresSQL DB support to the registries.