Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM 21146: Add support for PostgreSQL Registry #189

Merged
merged 13 commits into from
Aug 31, 2019
Merged

DM 21146: Add support for PostgreSQL Registry #189

merged 13 commits into from
Aug 31, 2019

Commits on Aug 30, 2019

  1. RDS backed Registry implementation. 

    Code was separated from a Draft-PR which contained both S3Datastore
and PostgreSqlRegistry into a self-standing PostgreSqlRegistry code
only.
    @DinoBektesevic
    DinoBektesevic committed Aug 30, 2019
    Configuration menu
    Copy the full SHA
    0da88ed View commit details
    Browse the repository at this point in the history

  2. Added PostgreSqlRegistry+PosixDatastore test to test_butler.py.

    @DinoBektesevic
    DinoBektesevic committed Aug 30, 2019
    Configuration menu
    Copy the full SHA
    90fa868 View commit details
    Browse the repository at this point in the history

  3. ConnectionStringBuilder class. 

    - transitioned connection strings to
  ConnectionStringBuilder
- added tests for ConnectionStringBuilder
- added class attributes for desired default
  values of dialect and driver

Removed RDSButlerTestCase.
Rebased onto master.
    @DinoBektesevic
    DinoBektesevic committed Aug 30, 2019
    Configuration menu
    Copy the full SHA
    5b7cbfd View commit details
    Browse the repository at this point in the history

  4. Review fixes requested by Andy. 

    Rebased onto master.
Removed RDS tests and supporting files.
    @DinoBektesevic
    DinoBektesevic committed Aug 30, 2019
    Configuration menu
    Copy the full SHA
    5ce2d1f View commit details
    Browse the repository at this point in the history

  5. Moved ConnectionStringBuilder out of registry.py.

    @DinoBektesevic
    DinoBektesevic committed Aug 30, 2019
    Configuration menu
    Copy the full SHA
    ab60260 View commit details
    Browse the repository at this point in the history

  6. Automatically resolve correct Registry class from connection string d… 

    …ialect.
    @DinoBektesevic
    DinoBektesevic committed Aug 30, 2019
    Configuration menu
    Copy the full SHA
    e285544 View commit details
    Browse the repository at this point in the history

  7. Tentative implementation of ConnectionStringFactory and 

    ConnectionSttring classes.

Removed RegistryConfig 'cls' key from default configs.
The registry class is determined through the 'db' string except
in the cases when the 'cls' class is explicitly stated.
This includes ignoring the cls key in registry setConfigRoot.
Omit explicitly setting cls values.
    @DinoBektesevic
    DinoBektesevic committed Aug 30, 2019
    Configuration menu
    Copy the full SHA
    114bb0a View commit details
    Browse the repository at this point in the history

  8. Fix faulty registry class checks in Registry.

    @DinoBektesevic
    DinoBektesevic committed Aug 30, 2019
    Configuration menu
    Copy the full SHA
    1ea0dc1 View commit details
    Browse the repository at this point in the history

  9. Simplify connection string handling. 

    Remove ConnectionStringClass. Reduce code duplication by
moving the dialect and correct registry class doImport
statements to Registry. Fixed tests.
    @DinoBektesevic
    DinoBektesevic committed Aug 30, 2019
    Configuration menu
    Copy the full SHA
    6b3ba4c View commit details
    Browse the repository at this point in the history

  10. Review fixes requested by TimJ and KTLim. 

    Correct class resolution moved to Registry. Removed that logic
from Butler.makeRepo and Registry.fromConfig.

ConnectionStringFactory is now used only internaly in the Registry.
Removed the connection string handling from the registry subclasses.

Removed the ConnectionString classes. ConnectionStringFactory now
produces an SQLAlchemy URL instances. Added checks to avoid
reading username and password when not required.

Fixed OracleRegistry misshandling of config keys in
OracleRegistry.setConfigRoot.

Changed the create_engine calls on all registry subclasses to
reflect the changes.

Docs.
    @DinoBektesevic
    DinoBektesevic committed Aug 30, 2019
    Configuration menu
    Copy the full SHA
    ca94553 View commit details
    Browse the repository at this point in the history

  11. Review fixes. 

    ConnectionStringFactory.fromConfig is now a classmethod.
Fixes to Registry where this makes a difference.

Fix to a doc string return value.

Added missing comment about import having to be in a
method.
    @DinoBektesevic
    DinoBektesevic committed Aug 30, 2019
    Configuration menu
    Copy the full SHA
    a4348dd View commit details
    Browse the repository at this point in the history

  12. Clarify returned value type.

    @DinoBektesevic
    DinoBektesevic committed Aug 30, 2019
    Configuration menu
    Copy the full SHA
    cb8150b View commit details
    Browse the repository at this point in the history

  13. Review fixes. 

    Moved the getDialect, getRegistryClass and connectionString into
RegistryConfig and made them instance methods instead.

Moved RegistryConfig into its own module.

Circular import error is now handled in the ConnectionStringFactory
instead of in multiple places in RegistryConfig.

Fixes to ConnectionStringFactory (removal of useless code).
    @DinoBektesevic
    DinoBektesevic committed Aug 30, 2019
    Configuration menu
    Copy the full SHA
    b184a7c View commit details
    Browse the repository at this point in the history