DM-24347: Allow a component dataset to be None #262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Code looks good; my only quibble is with the message on the final commit: I don't think that invalidates anything you've done here, but I think the message is wrong (or maybe just confusing, if I misunderstood it). |
TallJimbo
approved these changes
Apr 23, 2020
|
Yes, you are right when you don't disassemble the in-memory dataset. If you disassemble then we do not register the |
InMemoryDatastore can not ingest so in a ChainedDatastore it will complain when a dataset is trashed that it knew nothing about. We may want to have finer control of logging when a ChainedDatastore is involved since chaining by definition allows datasets to be added to some child datastores but not others.
Sometimes when we store a dataset, not all the components are define. This happens when datasets are disassembled. In other cases we do get a registry entry for each component and that component might be None.
Be explicit about whether we expect a None or a real entity.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes when we store a dataset, not all the components are defined. Registry won't register them in that case but there are some code paths that will still cause a datastore to try to return a None component.