Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-24347: Allow a component dataset to be None #262

Merged
merged 5 commits into from
Apr 24, 2020
Merged

DM-24347: Allow a component dataset to be None #262

merged 5 commits into from
Apr 24, 2020

Commits on Apr 23, 2020

  1. Allow example metrics to have None for data

    @timj
    timj committed Apr 23, 2020
    Configuration menu
    Copy the full SHA
    6aba13b View commit details
    Browse the repository at this point in the history

  2. Make note about warning message from test 

    InMemoryDatastore can not ingest so in a ChainedDatastore
it will complain when a dataset is trashed that it knew
nothing about. We may want to have finer control of logging
when a ChainedDatastore is involved since chaining by definition
allows datasets to be added to some child datastores but
not others.
    @timj
    timj committed Apr 23, 2020
    Configuration menu
    Copy the full SHA
    76ec3b9 View commit details
    Browse the repository at this point in the history

  3. Allow a component of a dataset to be None 

    Sometimes when we store a dataset, not all the components
are define. This happens when datasets are disassembled.
In other cases we do get a registry entry for each
component and that component might be None.
    @timj
    timj committed Apr 23, 2020
    Configuration menu
    Copy the full SHA
    c4ea39d View commit details
    Browse the repository at this point in the history

  4. Tweak the datastore formatter error message to include more info

    @timj
    timj committed Apr 23, 2020
    Configuration menu
    Copy the full SHA
    6c062f6 View commit details
    Browse the repository at this point in the history

  5. Expand the test for reading FITS components 

    Be explicit about whether we expect a None or a real entity.
    @timj
    timj committed Apr 23, 2020
    Configuration menu
    Copy the full SHA
    2c6b531 View commit details
    Browse the repository at this point in the history