DM-25818: Allow datastore.put to overwrite the stored file #342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timj
force-pushed
the
tickets/DM-25818
branch
3 times, most recently
from
388c412
to
cac8e1c
Compare
ktlim
approved these changes
Aug 7, 2020
timj
force-pushed
the
tickets/DM-25818
branch
2 times, most recently
from
5deb29e
to
343836a
Compare
If registry doesn't think it should exist then datastore should allow the overwrite. This can go wrong if a file template is not unique such that different datasets can end up with the same file name. It may also be possible for the file to exist but be in the trash table. In that situation the file might get deleted when the trash is emptied.
This makes us a bit less worried about filenames being duplicated in error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.