Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-25818: Allow datastore.put to overwrite the stored file #342

Merged
merged 4 commits into from
Aug 11, 2020
Merged

DM-25818: Allow datastore.put to overwrite the stored file #342

merged 4 commits into from
Aug 11, 2020

Commits on Aug 11, 2020

  1. Use the public property not the private one for bridge

    @timj
    timj committed Aug 11, 2020
    Configuration menu
    Copy the full SHA
    3dbf42e View commit details
    Browse the repository at this point in the history

  2. Add overwrite option to ButlerURI.transfer_from

    @timj
    timj committed Aug 11, 2020
    Configuration menu
    Copy the full SHA
    c6bb5ee View commit details
    Browse the repository at this point in the history

  3. Remove check for artifact existence on datastore.put 

    If registry doesn't think it should exist then
datastore should allow the overwrite.

This can go wrong if a file template is not unique such
that different datasets can end up with the same file name.

It may also be possible for the file to exist but be
in the trash table. In that situation the file might get
deleted when the trash is emptied.
    @timj
    timj committed Aug 11, 2020
    Configuration menu
    Copy the full SHA
    68eceff View commit details
    Browse the repository at this point in the history

  4. Always do template validation in datastore 

    This makes us a bit less worried about filenames being duplicated
in error.
    @timj
    timj committed Aug 11, 2020
    Configuration menu
    Copy the full SHA
    581e80b View commit details
    Browse the repository at this point in the history