DM-27354: Update for sphgeom pip install #423
Conversation
| @@ -2,7 +2,7 @@ pyyaml >= 5.1 | |||
| astropy >= 4.0 | |||
| click >= 7.0 | |||
| sqlalchemy >= 1.3 | |||
| https://github.com/lsst/sphgeom/archive/master.tar.gz | |||
| git+git://github.com/lsst/sphgeom@master#egg=lsst_sphgeom | |||
There was a problem hiding this comment.
why is this better than the previous URL?
There was a problem hiding this comment.
I spent some time trying to find documentation about this. The following is the best link I found: https://pip.pypa.io/en/stable/reference/pip_install/#requirement-specifiers
and it pointed me to the following for the various git protocols: https://git-scm.com/book/en/v2/Git-on-the-Server-The-Protocols
If I read this correctly I think the main advantage to git+git is speed. It can only be used for unauthenticated read, which is fine for this use case. The "cons" section of that document talks about the fact that the port is often blocked by corporate firewalls, which is worrisome.
|
We've done the big push so I'm fine with the sphgeom PR and this PR being merged at any time. |
sphgeom no longer has a requirements.txt file, so this commit removes the step from the build_and_test workflow that executes such a requirements.txt file. Secondly, the install_requires dependency listing in setup.cfg now installs sphgeom from GitHub, making the sphgeom installation from a requirements.txt file unnecessary.
timj
force-pushed
the
tickets/DM-27354
branch
from
762c33a
to
ef5e92f
Compare
Previously we got them implicitly.
sphgeom no longer has a requirements.txt file (as of lsst/sphgeom#30), so this PR removes the step from the build_and_test workflow that executes such a requirements.txt file.
Secondly, the install_requires dependency listing in setup.cfg now installs sphgeom from GitHub, making the sphgeom installation from a requirements.txt file unnecessary.
Note that this PR's build is expected to fail until the sphgeom PR is merged. Both PRs will need to be merged in quick succession.