Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-31723: Replace ButlerURI implementation with ResourcePath #611

Merged
merged 5 commits into from Dec 3, 2021

Conversation

timj
Copy link
Member

@timj timj commented Dec 3, 2021

Requires lsst/resources#1

Checklist

  • ran Jenkins
  • added a release note for user-visible changes to doc/changes

No longer an eups package.
Needed for new external implementation of ButlerURI
The code still uses ButlerURI and ButlerURI is exported as
an alias for ResourcePath. Changing the code will be a later
ticket.
@codecov
Copy link

codecov bot commented Dec 3, 2021

Codecov Report

Merging #611 (5077bea) into main (1427568) will increase coverage by 0.10%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #611      +/-   ##
==========================================
+ Coverage   83.68%   83.78%   +0.10%     
==========================================
  Files         242      231      -11     
  Lines       30715    29609    -1106     
  Branches     5121     4910     -211     
==========================================
- Hits        25703    24809     -894     
+ Misses       3814     3669     -145     
+ Partials     1198     1131      -67     
Impacted Files Coverage Δ
python/lsst/daf/butler/core/_butlerUri.py 100.00% <100.00%> (ø)
tests/test_butler.py 97.57% <100.00%> (ø)
tests/test_location.py 98.95% <100.00%> (ø)
tests/test_uri.py 97.48% <100.00%> (ø)
python/lsst/daf/butler/core/location.py 84.14% <0.00%> (-2.44%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1427568...5077bea. Read the comment docs.

@timj timj merged commit 12fcbbd into main Dec 3, 2021
@timj timj deleted the tickets/DM-31723 branch December 3, 2021 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant