DM-31723: Update code for new name and location #1
Conversation
timj
force-pushed
the
tickets/DM-31723
branch
from
5ecfa54
to
e8be588
Compare
Codecov Report
@@ Coverage Diff @@
## main #1 +/- ##
=======================================
Coverage ? 83.57%
=======================================
Files ? 13
Lines ? 1826
Branches ? 263
=======================================
Hits ? 1526
Misses ? 217
Partials ? 83 Continue to review full report at Codecov.
|
The repository was converted from daf_butler @ commit 5039d9a8 using git filter-repo --path python/lsst/daf/butler/core/_butlerUri/ --path python/lsst/daf/butler/core/_butlerUri.py \ --path python/lsst/daf/butler/core/location.py \ --path tests/test_uri.py \ --path tests/test_location.py \ --path-rename python/lsst/daf/butler/core/_butlerUri/:python/lsst/butlerUri/ \ --path-rename python/lsst/daf/butler/core/_butlerUri.py:python/lsst/butlerUri/__init__.py \ --path ups --path-rename python/lsst/daf/butler/core/location.py:python/lsst/butlerUri/location.py
timj
force-pushed
the
tickets/DM-31723
branch
from
2be2ee2
to
e6ca17a
Compare
The ButlerURI class is now ResourcePath.
This lets other packages find the type annotations.
timj
force-pushed
the
tickets/DM-31723
branch
2 times, most recently
from
7c60607
to
a2b61c5
Compare
.github/workflows/black.yaml
Outdated
| - uses: actions/checkout@v2 | ||
| - uses: psf/black@stable | ||
| with: | ||
| options: "--check --verbose --diff --line-length 110 --target-version py38" |
There was a problem hiding this comment.
@TallJimbo I've turned on black in this repo to see how we get on. These options seemed reasonable.
There was a problem hiding this comment.
and I realized I could put those options in the pyproject.toml file.
There was a problem hiding this comment.
We probably want isort in the same action; here's what I did recently for the combo:
https://github.com/lsst-dm/cell_coadds/blob/main/.github/workflows/formatting.yaml
https://github.com/lsst-dm/cell_coadds/blob/main/pyproject.toml
There was a problem hiding this comment.
Okay done. I've also committed a pre-commit config file.
timj
force-pushed
the
tickets/DM-31723
branch
from
a2b61c5
to
46b4833
Compare
timj
force-pushed
the
tickets/DM-31723
branch
from
46b4833
to
93f6973
Compare
E203 has to be disabled in flake8 testing to accomodate black. Turns out that flake8 is wrong.
timj
force-pushed
the
tickets/DM-31723
branch
from
93f6973
to
1b304b1
Compare
Prior to this the code assumed that it was in daf_butler and had no build infrastructure in the history.