DM-33155: Also allow storage class conversion on butler.put #626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #626 +/- ##
==========================================
+ Coverage 84.10% 84.11% +0.01%
==========================================
Files 237 237
Lines 30035 30050 +15
Branches 4990 4990
==========================================
+ Hits 25260 25277 +17
+ Misses 3638 3635 -3
- Partials 1137 1138 +1
Continue to review full report at Codecov.
|
2 tasks
timj
force-pushed
the
tickets/DM-33155
branch
from
40d1c76
to
42915f2
Compare
TallJimbo
approved these changes
Jan 10, 2022
The infrastructure already existed to support it and there is no particular reason why get should convert but put should not. Doing this provides a way for newer classes to be used in code but whilst still supporting old dataset type definitions.
We run runPutGetTest a lot and sometimes we run it just to get a configured butler with some dimensions and a dataset type defined. Move the set up code into a different method and now the put coercion test can use it and so be a little bit faster.
pydantic was missing from setup.cfg and psutil was still there for utils but utils should bring it in now.
timj
force-pushed
the
tickets/DM-33155
branch
from
4e24bc0
to
d781e5d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The infrastructure already existed to support it and there
is no particular reason why get should convert but put
should not. Doing this provides a way for newer classes
to be used in code but whilst still supporting old
dataset type definitions.
Checklist
doc/changes