DM-33155: Change how task metadata storage class is chosen #223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The dict() method converts it to the internal model form of the class with distinct sections for scalars, arrays, and metadata. The to_dict() method looks like something the user would expect the content to look like.
Previously the task_metadata storage classes use a definition that matches the metadata python type attached to the Task. Butler can now do type conversion on put and get so prefer a metadata storage class that matches the current definition. New metadata dataset types will use the default. This allows old registries to use old dataset type definitions without having to migrate them all but still allow Task to use updated metadata class.
No longer use PropertySet by default.
TallJimbo
approved these changes
Jan 10, 2022
Now that TaskMetadata can be converted to PropertySet there is no need for Task to support both.
|
@TallJimbo I realized that there is no need to continue to support the PropertySet switch at the top of the file so I removed that code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TaskMetadata.to_dict()method (this is now used by thePropertySet.from_mapping()method and triggered by the butler if type conversion is needed).Taskto useTaskMetadatarather thanPropertySetRequires lsst/daf_butler#626 and lsst/daf_base#72
Checklist
doc/changes