DM-33271: Fix mypy warnings with 0.931 #631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not all the cases where str+ResourcePath were converted to ResourcePathExpression were correct and some were missed.
mypy can't tell the type returned by a getattr so an assert must be included.
types.Mapping expects .keys() to return KeysView but these classes return an AbstractSet. The set is compatible with KeysView to the extent we need but KeysView is a concrete class and not an abstract one so it is not desirable to involve it. For now this means we ignore the warning.
FileDataset always assumed this was mandatory but this was only just enforced.
Codecov Report
@@ Coverage Diff @@
## main #631 +/- ##
==========================================
- Coverage 84.11% 84.11% -0.01%
==========================================
Files 237 237
Lines 30138 30143 +5
Branches 5014 5014
==========================================
+ Hits 25351 25354 +3
- Misses 3643 3645 +2
Partials 1144 1144
Continue to review full report at Codecov.
|
Some versions of mypy get upset with the return type for ButlerURI.__new__ not being ButlerURI. Others do not complain. Since this is purely a compatibility layer, configure mypy to ignore the errors if they happen.
TallJimbo
approved these changes
Jan 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
doc/changes