Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-33271: Fix mypy warnings with 0.931 #631

Merged
merged 12 commits into from
Jan 15, 2022
Merged

DM-33271: Fix mypy warnings with 0.931 #631

merged 12 commits into from
Jan 15, 2022

Commits on Jan 14, 2022

  1. Fix some issues with ResourcePathExpression 

    Not all the cases where str+ResourcePath were converted
to ResourcePathExpression were correct and some were
missed.
    @timj
    timj committed Jan 14, 2022
    Configuration menu
    Copy the full SHA
    8145f51 View commit details
    Browse the repository at this point in the history

  2. Mypy does not want ButlerURI to return ResourcePath so ignore

    @timj
    timj committed Jan 14, 2022
    Configuration menu
    Copy the full SHA
    aebb0e7 View commit details
    Browse the repository at this point in the history

  3. Fix problem with mypy and getattr 

    mypy can't tell the type returned by a getattr so an
assert must be included.
    @timj
    timj committed Jan 14, 2022
    Configuration menu
    Copy the full SHA
    308c720 View commit details
    Browse the repository at this point in the history

  4. Remove unused type ignore

    @timj
    timj committed Jan 14, 2022
    Configuration menu
    Copy the full SHA
    222e068 View commit details
    Browse the repository at this point in the history

  5. Unpin mypy version in action

    @timj
    timj committed Jan 14, 2022
    Configuration menu
    Copy the full SHA
    13c89bf View commit details
    Browse the repository at this point in the history

  6. Ignore keys return values in named mappings 

    types.Mapping expects .keys() to return KeysView but
these classes return an AbstractSet. The set is compatible
with KeysView to the extent we need but KeysView is
a concrete class and not an abstract one so it is not
desirable to involve it. For now this means we ignore
the warning.
    @timj
    timj committed Jan 14, 2022
    Configuration menu
    Copy the full SHA
    80e8f6d View commit details
    Browse the repository at this point in the history

  7. Ensure that paths aren't made absolute

    @timj
    timj committed Jan 14, 2022
    Configuration menu
    Copy the full SHA
    3f8c197 View commit details
    Browse the repository at this point in the history

  8. Disable strict yaml check

    @timj
    timj committed Jan 14, 2022
    Configuration menu
    Copy the full SHA
    1061e04 View commit details
    Browse the repository at this point in the history

  9. Force a placeholder path in dataset yaml 

    FileDataset always assumed this was mandatory but this was
only just enforced.
    @timj
    timj committed Jan 14, 2022
    Configuration menu
    Copy the full SHA
    3442941 View commit details
    Browse the repository at this point in the history

  10. Appease mypy by insisting that only a str is used as a key

    @timj
    timj committed Jan 14, 2022
    Configuration menu
    Copy the full SHA
    066d287 View commit details
    Browse the repository at this point in the history

  11. Ignore errors from ButlerURI 

    Some versions of mypy get upset with the return type for
ButlerURI.__new__ not being ButlerURI. Others do not complain.
Since this is purely a compatibility layer, configure mypy
to ignore the errors if they happen.
    @timj
    timj committed Jan 14, 2022
    Configuration menu
    Copy the full SHA
    f0c8fd3 View commit details
    Browse the repository at this point in the history

  12. Add missing __all__

    @timj
    timj committed Jan 14, 2022
    Configuration menu
    Copy the full SHA
    f774ee9 View commit details
    Browse the repository at this point in the history