Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-34105: Move Packages formatter from obs_base #663

Merged
merged 5 commits into from Mar 23, 2022
Merged

Conversation

timj
Copy link
Member

@timj timj commented Mar 21, 2022

Pex Config formatter has been relocated to pipe_base (requires lsst/pipe_base#239)

Checklist

  • ran Jenkins
  • added a release note for user-visible changes to doc/changes

@codecov
Copy link

codecov bot commented Mar 21, 2022

Codecov Report

Merging #663 (151fc69) into main (2036ad5) will decrease coverage by 0.01%.
The diff coverage is 74.13%.

@@            Coverage Diff             @@
##             main     #663      +/-   ##
==========================================
- Coverage   83.72%   83.70%   -0.02%     
==========================================
  Files         239      241       +2     
  Lines       30525    30583      +58     
  Branches     5120     5127       +7     
==========================================
+ Hits        25558    25601      +43     
- Misses       3811     3823      +12     
- Partials     1156     1159       +3     
Impacted Files Coverage Δ
python/lsst/daf/butler/cli/cmd/__init__.py 100.00% <ø> (ø)
python/lsst/daf/butler/cli/opt/__init__.py 100.00% <ø> (ø)
python/lsst/daf/butler/script/__init__.py 100.00% <ø> (ø)
python/lsst/daf/butler/formatters/packages.py 62.85% <62.85%> (ø)
tests/test_packages.py 91.30% <91.30%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2036ad5...151fc69. Read the comment docs.

Copy link
Contributor

@andy-slac andy-slac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great

python/lsst/daf/butler/formatters/packages.py Outdated Show resolved Hide resolved
python/lsst/daf/butler/formatters/packages.py Outdated Show resolved Hide resolved
python/lsst/daf/butler/formatters/packages.py Outdated Show resolved Hide resolved
@timj timj force-pushed the tickets/DM-34105 branch 4 times, most recently from 76fdf94 to 16302a2 Compare March 23, 2022 17:44
daf_butler depends on lsst.utils which now includes the Packages
class so the Packages formatter can now be made more widely available.
@timj timj merged commit a989976 into main Mar 23, 2022
@timj timj deleted the tickets/DM-34105 branch March 23, 2022 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants