DM-33942: Schema changes #674
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #674 +/- ##
==========================================
- Coverage 84.46% 84.41% -0.05%
==========================================
Files 243 243
Lines 31475 31516 +41
Branches 5882 5894 +12
==========================================
+ Hits 26584 26605 +21
- Misses 3726 3741 +15
- Partials 1165 1170 +5
Continue to review full report at Codecov.
|
timj
force-pushed
the
tickets/DM-33942
branch
3 times, most recently
from
5678d73
to
4de102a
Compare
2 tasks
timj
force-pushed
the
tickets/DM-33942
branch
5 times, most recently
from
d5a2405
to
f30a8d7
Compare
timj
force-pushed
the
tickets/DM-33942
branch
2 times, most recently
from
6207fdb
to
4bfe5fe
Compare
andy-slac
reviewed
May 19, 2022
timj
commented
May 20, 2022
TallJimbo
approved these changes
May 25, 2022
timj
force-pushed
the
tickets/DM-33942
branch
5 times, most recently
from
1b6ca21
to
5701023
Compare
If a dataset type is a calibration that uses seq_num it could be satisfied by visit or exposure. In that case always pick exposure because visit is a derived dimension and it may not yet have been defined.
A visit can now belong to multiple visit_systems, as long as the set of exposures computed by those visit_systems is the same.
It's quite inconveniet to specify a bit mask in a Registry SQL query so remove it and require that the visit_system_membership record be used instead.
* Remove visit system from dataset type dimensions. * Create visit_system_membership records.
A visit that is defined using day_obs/seq_num has an ambiguity in that it is possible for the one-to-one visit and the seq_start/seq_end visit to have the same values for day_obs/seq_num. Now explicitly catch an ambiguous visit and use the default visit system from the instrument record to determine which one is likely to be the desired one.
This has to be done for any substantive changes since it is used in caching.
Having null values in these columns already breaks the query system, so this should only break unit tests.
This does not catch a later change of primaryKey.
And use that version on import.
timj
commented
May 31, 2022
timj
commented
May 31, 2022
TallJimbo
approved these changes
May 31, 2022
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
doc/changes