New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DM-33942: Support schema changes for exposure/visit #416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timj
force-pushed
the
tickets/DM-33942
branch
3 times, most recently
from
April 20, 2022 23:07
de03b5d
to
d25ca21
Compare
Clarification from slack regarding define-visits:
If a multi-snap visit is missing one of the exposure records (generally expected to be the second one) it should be treated as a multi-snap visit even though the exposure_time and average az/el will be incorrect. Facility must be included to recalculate the multi-snap visit definition when/if the second exposure arrives. |
timj
force-pushed
the
tickets/DM-33942
branch
5 times, most recently
from
April 22, 2022 23:10
9a3b746
to
1f3f495
Compare
timj
commented
Apr 22, 2022
timj
force-pushed
the
tickets/DM-33942
branch
3 times, most recently
from
April 26, 2022 19:50
93aaa64
to
91c6aeb
Compare
TallJimbo
approved these changes
May 26, 2022
Adds a new exposure grouping class that groups by seq_start/seq_end and also creates visit for each exposure. This can only work with updated registry. The old scheme still works for old registry although the default grouping algorithm is not dynamic based on the schema version.
No longer allow the grouping task to define its own integer values for visit_systems.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on lsst/astro_metadata_translator#55 and lsst/daf_butler#674
Checklist
doc/changes