DM-36108: move Ellipsis typing workaround to utils #730
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
My in-editor mypy has long complained about these, even though the command-line one doesn't seem bothered by them. They're easy enough to fix.
TallJimbo
changed the title
timj
approved these changes
Sep 5, 2022
TallJimbo
force-pushed
the
tickets/DM-36108
branch
from
5bf3025
to
e8daa3a
Compare
Codecov Report
@@ Coverage Diff @@
## main #730 +/- ##
==========================================
+ Coverage 84.68% 84.69% +0.01%
==========================================
Files 244 244
Lines 32146 32141 -5
Branches 6035 6034 -1
==========================================
- Hits 27223 27222 -1
+ Misses 3749 3745 -4
Partials 1174 1174
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires lsst/utils#137; checks here should only pass after that has been merged long enough to it to be picked up as a dependency in the checks here.
Checklist
doc/changes