DM-36108: move Ellipsis typing workaround from daf_butler #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
My in-editor mypy has long complained about this, even though the command-line one doesn't seem bothered by it. It's easy enough to fix.
timj
approved these changes
Sep 5, 2022
TallJimbo
force-pushed
the
tickets/DM-36108
branch
from
a7206ef
to
8e6c4c7
Compare
Codecov Report
@@ Coverage Diff @@
## main #137 +/- ##
==========================================
- Coverage 92.24% 92.12% -0.13%
==========================================
Files 42 44 +2
Lines 2709 2729 +20
==========================================
+ Hits 2499 2514 +15
- Misses 210 215 +5
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
TallJimbo
force-pushed
the
tickets/DM-36108
branch
from
8e6c4c7
to
fd0e696
Compare
2 tasks
TallJimbo
force-pushed
the
tickets/DM-36108
branch
from
fd0e696
to
c28f55c
Compare
TallJimbo
commented
Sep 6, 2022
|
|
||
| from typing import TYPE_CHECKING | ||
|
|
||
| if TYPE_CHECKING: |
There was a problem hiding this comment.
It's expected for codecov to complain about this block, because by design it's only ever seen by MyPy and other type-checkers: we don't actually want it to run in tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
doc/changes