Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-36172: Add explicit transaction around moveToTrash calls #733

Merged
merged 4 commits into from
Sep 13, 2022

Commits on Sep 9, 2022

  1. No longer set MYPYPATH

    Modern mypy does not want it.
    timj committed Sep 9, 2022
    Configuration menu
    Copy the full SHA
    04572c9 View commit details
    Browse the repository at this point in the history

Commits on Sep 13, 2022

  1. Use datastore transactions in butler methods that trash datasets

    Butler does not know that a registry transaction is sufficient.
    
    This also add a transaction parameter to bridge moveToTrash method
    to make use of that new transaction context.
    
    Without this there is no way for the ephemeral bridge to roll
    back a transaction from a failure in registry. This works for
    the normal bridge because that is also using a shared
    database transaction.
    timj committed Sep 13, 2022
    Configuration menu
    Copy the full SHA
    74b4f7a View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    a782053 View commit details
    Browse the repository at this point in the history
  3. Add news fragment

    timj committed Sep 13, 2022
    Configuration menu
    Copy the full SHA
    3c82a35 View commit details
    Browse the repository at this point in the history