DM-36172: Add explicit transaction around moveToTrash calls #733
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modern mypy does not want it.
Codecov ReportBase: 84.69% // Head: 84.68% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #733 +/- ##
==========================================
- Coverage 84.69% 84.68% -0.02%
==========================================
Files 244 244
Lines 32141 32156 +15
Branches 6034 6040 +6
==========================================
+ Hits 27222 27230 +8
- Misses 3745 3752 +7
Partials 1174 1174
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
TallJimbo
approved these changes
Sep 10, 2022
Butler does not know that a registry transaction is sufficient. This also add a transaction parameter to bridge moveToTrash method to make use of that new transaction context. Without this there is no way for the ephemeral bridge to roll back a transaction from a failure in registry. This works for the normal bridge because that is also using a shared database transaction.
timj
force-pushed
the
tickets/DM-36172
branch
from
4139289
to
a782053
Compare
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this the in-memory datastore can not rollback a
datastore.trash()call.Checklist
doc/changes