DM-4551: Allow override of storage class on butler.get() #737
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 84.70% // Head: 84.75% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #737 +/- ##
==========================================
+ Coverage 84.70% 84.75% +0.04%
==========================================
Files 254 254
Lines 32894 32946 +52
Branches 5629 5632 +3
==========================================
+ Hits 27864 27922 +58
+ Misses 3803 3801 -2
+ Partials 1227 1223 -4
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
timj
force-pushed
the
tickets/DM-4551
branch
4 times, most recently
from
6722881
to
aefb1b6
Compare
timj
commented
Sep 30, 2022
2 tasks
TallJimbo
approved these changes
Sep 30, 2022
This can be useful when forcing storage class type conversions.
This test was there for when registry would disassemble and give datastore individual components. We no longer do this so there is no need to test the functionality, especially since that relied on special logic where the read and write storage classes did not match. Now we have storage class conversion infrastructure that test is no longer valid and datastore can just depend on whether a component has been requested without trying to guess from the storage class discrepancy that this has been an external disassembly.
The in-memory datastore was still trying to assume that the storage classes not matching meant that a component was being requested.
This is used to override the storage class associated with the requested dataset ref.
This should lead to a very quick error message before the data are retrieved.
timj
force-pushed
the
tickets/DM-4551
branch
2 times, most recently
from
74096b3
to
9d0128d
Compare
erykoff
reviewed
Oct 3, 2022
It has been pointed out that a butler.get always implies reading.
timj
commented
Oct 3, 2022
2 tasks
TallJimbo
approved these changes
Oct 4, 2022
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support
data = butler.getDirect(ref, readStorageClass="AstropyTable")style overrides.Checklist
doc/changes