Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-4551: Add support for storage class conversion on get from in-memory dataset handle #283

Merged
merged 2 commits into from Oct 4, 2022

Conversation

timj
Copy link
Member

@timj timj commented Oct 3, 2022

This matches the change to DeferredDatasetHandle (lsst/daf_butler#737)

@TallJimbo you probably should look at this and the new deferred dataset handle changes in daf_butler given I had completely forgotten about this when you did your original review.

Checklist

  • ran Jenkins
  • added a release note for user-visible changes to doc/changes

@codecov
Copy link

codecov bot commented Oct 3, 2022

Codecov Report

Base: 81.92% // Head: 81.99% // Increases project coverage by +0.06% 🎉

Coverage data is based on head (f9b04e8) compared to base (96a1ab1).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #283      +/-   ##
==========================================
+ Coverage   81.92%   81.99%   +0.06%     
==========================================
  Files          56       56              
  Lines        6103     6126      +23     
  Branches     1114     1118       +4     
==========================================
+ Hits         5000     5023      +23     
  Misses        873      873              
  Partials      230      230              
Impacted Files Coverage Δ
python/lsst/pipe/base/_dataset_handle.py 100.00% <100.00%> (ø)
tests/test_dataset_handle.py 97.10% <100.00%> (+0.67%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@timj timj requested a review from TallJimbo October 4, 2022 04:23
…t handle

This matches the change to DeferredDatasetHandle
@timj timj merged commit 00bbf2f into main Oct 4, 2022
@timj timj deleted the tickets/DM-4551 branch October 4, 2022 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants