DM-37995: Improve storage class override logic #791
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andy-slac
force-pushed
the
tickets/DM-37995
branch
from
60edc7a
to
89534f8
Compare
Codecov ReportBase: 85.54% // Head: 85.54% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #791 +/- ##
=======================================
Coverage 85.54% 85.54%
=======================================
Files 266 266
Lines 35137 35186 +49
Branches 7377 7388 +11
=======================================
+ Hits 30057 30100 +43
- Misses 3765 3768 +3
- Partials 1315 1318 +3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
timj
approved these changes
Feb 27, 2023
andy-slac
force-pushed
the
tickets/DM-37995
branch
from
4c9f5b1
to
738549a
Compare
In trusted mode the datastore has to use original registry storage class to search for artifacts. Because datastore has no access to registry a new method was added to Datastore class to specify a way to retrieve registry dataset type based on its name (dependency inversion). Butler instances use this new method to provide access to to dataset type mapping. In case of QBB, when registry does not exist this mapping has to be provided when constructing QBB.
Co-authored-by: Tim Jenness <tjenness@lsst.org>
andy-slac
force-pushed
the
tickets/DM-37995
branch
from
738549a
to
d6265b5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In trusted mode the datastore has to use original registry storage class
to search for artifacts. Because datastore has no access to registry
a new method was added to Datastore class to specify a way to retrieve
registry dataset type based on its name (dependency inversion).
Butler instances use this new method to provide access to to dataset
type mapping. In case of QBB, when registry does not exist this mapping
has to be provided when constructing QBB.
Checklist
doc/changes