Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-37995: Improve storage class override logic #791

Merged
merged 3 commits into from
Feb 28, 2023
Merged

DM-37995: Improve storage class override logic #791

merged 3 commits into from
Feb 28, 2023

Commits on Feb 28, 2023

  1. Add unit test for storage class compatibility in trusted mode

    @andy-slac
    andy-slac committed Feb 28, 2023
    Configuration menu
    Copy the full SHA
    777e928 View commit details
    Browse the repository at this point in the history

  2. Improve storage class override logic (DM-37995) 

    In trusted mode the datastore has to use original registry storage class
to search for artifacts. Because datastore has no access to registry
a new method was added to Datastore class to specify a way to retrieve
registry dataset type based on its name (dependency inversion).

Butler instances use this new method to provide access to to dataset
type mapping. In case of QBB, when registry does not exist this mapping
has to be provided when constructing QBB.
    @andy-slac
    andy-slac committed Feb 28, 2023
    Configuration menu
    Copy the full SHA
    086ac16 View commit details
    Browse the repository at this point in the history

  3. Apply suggestions from code review 

    Co-authored-by: Tim Jenness <tjenness@lsst.org>
    @andy-slac @timj
    andy-slac and timj committed Feb 28, 2023
    Configuration menu
    Copy the full SHA
    d6265b5 View commit details
    Browse the repository at this point in the history