DM-39665: Remove faked DataCoordinate from all tests #852
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #852 +/- ##
==========================================
- Coverage 88.01% 87.98% -0.03%
==========================================
Files 269 269
Lines 35514 35435 -79
Branches 7442 7429 -13
==========================================
- Hits 31258 31178 -80
- Misses 3113 3114 +1
Partials 1143 1143
☔ View full report in Codecov by Sentry. |
timj
changed the title
timj
commented
Jun 15, 2023
| @@ -91,26 +88,21 @@ def _makeDatasetRef( | |||
|
|
|||
| if run is None: | |||
| run = "dummy" | |||
| dataId = DataCoordinate.standardize(dataId, graph=datasetType.dimensions) | |||
There was a problem hiding this comment.
Now that everything conforms in the code calling this I think I can delete this line (I had to add it whilst I was testing things). We don't even annotate this method as taking Mapping for dataId.
There was a problem hiding this comment.
I had to leave it in but I only call it for a dict parameter since we do pass in dicts from the tests.
Mostly required adding some band values to DataIds.
Since we now always convert to DataCoordinate these are no longer needed.
No longer needed now that DatasetRef automatically creates one.
Not mypy clean but this is a start.
Tests use dicts and now expect it to be converted to DatasetRef
TallJimbo
approved these changes
Jun 16, 2023
Core butler code should not assume that "instrument" is in the universe.
Add fake values for the missing dimensions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
doc/changes