Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-39665: Remove faked DataCoordinate from all tests #852

Merged
merged 16 commits into from
Jun 16, 2023
Merged

DM-39665: Remove faked DataCoordinate from all tests #852

merged 16 commits into from
Jun 16, 2023

Commits on Jun 14, 2023

  1. Add type annotations to test_datasets

    @timj
    timj committed Jun 14, 2023
    Configuration menu
    Copy the full SHA
    5e8767c View commit details
    Browse the repository at this point in the history

  2. Use full DataCoordinate rather than dict for validation

    @timj
    timj committed Jun 14, 2023
    Configuration menu
    Copy the full SHA
    1209728 View commit details
    Browse the repository at this point in the history

Commits on Jun 15, 2023

  1. Make tests pass using full DataCoordinate 

    Mostly required adding some band values to DataIds.
    @timj
    timj committed Jun 15, 2023
    Configuration menu
    Copy the full SHA
    3619e13 View commit details
    Browse the repository at this point in the history

  2. Remove unnecessary DataIdForTest and FakeDataCoordinate classes 

    Since we now always convert to DataCoordinate these are no
longer needed.
    @timj
    timj committed Jun 15, 2023
    Configuration menu
    Copy the full SHA
    b81b5ce View commit details
    Browse the repository at this point in the history

  3. Fix some missing annotations on test_butler.py

    @timj
    timj committed Jun 15, 2023
    Configuration menu
    Copy the full SHA
    d0bb204 View commit details
    Browse the repository at this point in the history

  4. Remove ID setting in datastore test helper 

    No longer needed now that DatasetRef automatically creates one.
    @timj
    timj committed Jun 15, 2023
    Configuration menu
    Copy the full SHA
    a3ea7a4 View commit details
    Browse the repository at this point in the history

  5. Add some missing type annotations 

    Not mypy clean but this is a start.
    @timj
    timj committed Jun 15, 2023
    Configuration menu
    Copy the full SHA
    1070f2b View commit details
    Browse the repository at this point in the history

  6. Remove conform=False in datastore tests since we do now conform

    @timj
    timj committed Jun 15, 2023
    Configuration menu
    Copy the full SHA
    31a9cf7 View commit details
    Browse the repository at this point in the history

  7. Fix spelling typo

    @timj
    timj committed Jun 15, 2023
    Configuration menu
    Copy the full SHA
    73088e3 View commit details
    Browse the repository at this point in the history

  8. Use TestCaseMixin to help mypy in test_datastore

    @timj
    timj committed Jun 15, 2023
    Configuration menu
    Copy the full SHA
    87593d9 View commit details
    Browse the repository at this point in the history

  9. Allow Mapping in makeDatasetRef 

    Tests use dicts and now expect it to be converted to DatasetRef
    @timj
    timj committed Jun 15, 2023
    Configuration menu
    Copy the full SHA
    5a793b8 View commit details
    Browse the repository at this point in the history

  10. Need the root to also be None in tests

    @timj
    timj committed Jun 15, 2023
    Configuration menu
    Copy the full SHA
    53c7737 View commit details
    Browse the repository at this point in the history

  11. More annotation improvements in tests

    @timj
    timj committed Jun 15, 2023
    Configuration menu
    Copy the full SHA
    00dcbf2 View commit details
    Browse the repository at this point in the history

Commits on Jun 16, 2023

  1. Only query instrument if instrument is in universe for validation 

    Core butler code should not assume that "instrument" is in
the universe.
    @timj
    timj committed Jun 16, 2023
    Configuration menu
    Copy the full SHA
    821c27e View commit details
    Browse the repository at this point in the history

  2. Use conforming dataId for validation of instrument DatasetRef 

    Add fake values for the missing dimensions.
    @timj
    timj committed Jun 16, 2023
    Configuration menu
    Copy the full SHA
    78aa265 View commit details
    Browse the repository at this point in the history

  3. Add news fragment

    @timj
    timj committed Jun 16, 2023
    Configuration menu
    Copy the full SHA
    c49c090 View commit details
    Browse the repository at this point in the history