DM-41043: internal package reorganization #892
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 5, 2023
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #892 +/- ##
==========================================
+ Coverage 87.70% 87.74% +0.04%
==========================================
Files 272 271 -1
Lines 36190 36358 +168
Branches 7572 7572
==========================================
+ Hits 31739 31903 +164
- Misses 3270 3273 +3
- Partials 1181 1182 +1
☔ View full report in Codecov by Sentry. |
This was referenced Oct 5, 2023
TallJimbo
force-pushed
the
tickets/DM-41043
branch
from
63bc1b8
to
75ee13d
Compare
2 tasks
timj
approved these changes
Oct 9, 2023
The base Datastore class is lifted to `lsst.daf.butler.datastore.Datastore`, but other modules are expected to be imported directly from their lower-level modules.
This required a small change to class variables in StorageClass; it turns out the previous approach was (weakly) vulnerable to the order in which modules appear in __init__.py since it called get_full_type_name in import-time logic.
Symbols weren't being lifted, so this shouldn't get a leading underscore.
These are part of the Formatter API, and as much as we'd like it to be that's not just a FileDatastore implementation detail right now.
This also fixes some long-standing warnings and the fact that the old doc index didn't really reflect the old package structure.
TallJimbo
force-pushed
the
tickets/DM-41043
branch
from
81f6ccc
to
7768e59
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
doc/changes