Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-42567: Fix missing auth headers in RemoteButler #943

Merged
merged 2 commits into from Jan 19, 2024
Merged

DM-42567: Fix missing auth headers in RemoteButler #943

merged 2 commits into from Jan 19, 2024

Conversation

dhirving
Copy link
Contributor

@dhirving dhirving commented Jan 19, 2024 •
edited

Checklist

  • ran Jenkins
  • added a release note for user-visible changes to doc/changes

@dhirving
Use function for creating server instead of global
62d091d 
In an upcoming commit, I need to add a custom middleware only during unit testing.  We now can instantiate separate instances of the app, to prevent tests from polluting each other's environment.
@dhirving
Fix missing authentication headers
c62735a 
When I refactored the way the HTTP client was used in RemoteButler, I failed to update a few of the locations where it was used.  As a result, some methods were not including the required authentication headers.
@codecov Codecov
Copy link

codecov bot commented Jan 19, 2024 •
edited

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (1fab958) 88.37% compared to head (c62735a) 88.37%.
Report is 1 commits behind head on main.

Files Patch % Lines
python/lsst/daf/butler/tests/server_utils.py 80.95% 2 Missing and 2 partials ⚠️
tests/test_server.py 90.90% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #943      +/-   ##
==========================================
- Coverage   88.37%   88.37%   -0.01%     
==========================================
  Files         301      303       +2     
  Lines       38945    38979      +34     
  Branches     8213     8221       +8     
==========================================
+ Hits        34418    34448      +30     
- Misses       3337     3339       +2     
- Partials     1190     1192       +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dhirving dhirving merged commit e027dc4 into main Jan 19, 2024
17 of 18 checks passed
@dhirving dhirving deleted the tickets/DM-42567 branch January 19, 2024 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timj timj timj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dhirving @timj