Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-42567: Fix missing auth headers in RemoteButler #943

Merged
merged 2 commits into from
Jan 19, 2024
Merged

DM-42567: Fix missing auth headers in RemoteButler #943

merged 2 commits into from
Jan 19, 2024

Commits on Jan 19, 2024

  1. Use function for creating server instead of global 

    In an upcoming commit, I need to add a custom middleware only during unit testing.  We now can instantiate separate instances of the app, to prevent tests from polluting each other's environment.
    @dhirving
    dhirving committed Jan 19, 2024
    Configuration menu
    Copy the full SHA
    62d091d View commit details
    Browse the repository at this point in the history

  2. Fix missing authentication headers 

    When I refactored the way the HTTP client was used in RemoteButler, I failed to update a few of the locations where it was used.  As a result, some methods were not including the required authentication headers.
    @dhirving
    dhirving committed Jan 19, 2024
    Configuration menu
    Copy the full SHA
    c62735a View commit details
    Browse the repository at this point in the history