DM-42636: add group and day_obs first-class dimensions #953
Commits on Feb 29, 2024
-
Fix astropy warning with timespan calculation
The offset was meant to be "offset * (n + 1)" not an offset of n minutes plus one day.
-
-
-
-
Update HSC test data to new universe version, add day_obs.
This file was so old it predated the addition of day_obs to the exposure and visit dimensions, and that was back before we even had a dimension universe version. While it's nice to have the YAML import code migrate simple things, it has no idea where an instrument is and hence can't handle this one. Procedure was: - make an empty SQLite repo - import the old file - query for visit dimensions (there are no exposures in this file) - make new records with day_obs set, by looking at visit.timespan.begin and doing some timezone stuff (HSC is in Hawaii, which I just hard-coded here) - re-insert the new visit recods with replace=True - export all of the dimension elements in butler.dimensions.elements with element.has_own_table=True.
-
-
This updates the YAML file to have day_obs as a dimension rather than rely on the import-time migration, which warns.
-
Ensure that for import we insert records in the correct order
This ensures we do not try to load exposure before we've loaded day_obs.
-
Ensure that derived serialized dimension record name has no underscores
We want SpecificSerializedDimensionRecordDayObs and not SpecificSerializedDimensionRecordDay_obs.
-
-
-
-
-
Add a test reading a version 0 export YAML file
This required that code is added to derive day_obs from the datetime_begin field (something which should have been added long ago when universe version 1 came out).
-
-
-
-
-
Remove day_obs_offset from instrument record
Instead always try to get the offset from the attached instrument class's metadata translator.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.