DM-42636: add group and day_obs first-class dimensions #953
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #953 +/- ##
==========================================
- Coverage 88.53% 88.52% -0.01%
==========================================
Files 313 313
Lines 40036 40182 +146
Branches 8371 8407 +36
==========================================
+ Hits 35444 35570 +126
- Misses 3379 3392 +13
- Partials 1213 1220 +7 ☔ View full report in Codecov by Sentry. |
timj
force-pushed
the
tickets/DM-42636
branch
from
0449ec0
to
bbac61a
Compare
2 tasks
timj
force-pushed
the
tickets/DM-42636
branch
3 times, most recently
from
b1ec31a
to
3458a15
Compare
2 tasks
TallJimbo
commented
Feb 20, 2024
timj
force-pushed
the
tickets/DM-42636
branch
6 times, most recently
from
e415293
to
26df6f2
Compare
TallJimbo
commented
Feb 28, 2024
kfindeisen
added a commit
to lsst-dm/prompt_processing
that referenced
this pull request
Feb 28, 2024
Previously, the only way to reconstruct the history was to run git blame on dimensions.yaml. lsst/daf_butler#953 will add human-curated documentation to the Pipelines docs.
kfindeisen
added a commit
to lsst-dm/prompt_processing
that referenced
this pull request
Feb 28, 2024
Previously, the only way to reconstruct the history was to run git blame on dimensions.yaml. lsst/daf_butler#953 will add human-curated documentation to the Pipelines docs.
kfindeisen
added a commit
to lsst-dm/prompt_processing
that referenced
this pull request
Feb 28, 2024
Previously, the only way to reconstruct the history was to run git blame on dimensions.yaml. lsst/daf_butler#953 will add human-curated documentation to the Pipelines docs.
The offset was meant to be "offset * (n + 1)" not an offset of n minutes plus one day.
This file was so old it predated the addition of day_obs to the exposure and visit dimensions, and that was back before we even had a dimension universe version. While it's nice to have the YAML import code migrate simple things, it has no idea where an instrument is and hence can't handle this one. Procedure was: - make an empty SQLite repo - import the old file - query for visit dimensions (there are no exposures in this file) - make new records with day_obs set, by looking at visit.timespan.begin and doing some timezone stuff (HSC is in Hawaii, which I just hard-coded here) - re-insert the new visit recods with replace=True - export all of the dimension elements in butler.dimensions.elements with element.has_own_table=True.
This updates the YAML file to have day_obs as a dimension rather than rely on the import-time migration, which warns.
This ensures we do not try to load exposure before we've loaded day_obs.
We want SpecificSerializedDimensionRecordDayObs and not SpecificSerializedDimensionRecordDay_obs.
Only back to version 1.
This required that code is added to derive day_obs from the datetime_begin field (something which should have been added long ago when universe version 1 came out).
Instead always try to get the offset from the attached instrument class's metadata translator.
timj
force-pushed
the
tickets/DM-42636
branch
from
26df6f2
to
58e02cb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on lsst/astro_metadata_translator#71.
Checklist
doc/changes