DM-16160: Restore pre-insert uniqueness check in addDataset(). #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hod" (DM-16160) Fix will be needed for this commit, in its current for it breaks obs_subaru unit test. Current schema lacks actual constraints for collections, this commit adds code to verify that added rows do not violate constraints. It can only work reliably in single-user environment, we have to move constraints to schema definition for more reliable validation.
Also pass transactional=False when calling associate() from addDataset(). This is a workaround for previous commit breaking obs_subaru unit tests. Actual problem lies deeper in transaction management in lsst.obs.base.ingest module, that will have to be fixed later, see discussion on (DM-16160)
TallJimbo
approved these changes
Oct 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-apply commit 7f85ed5: "Implement constraint check in associate method"
and testore pre-insert uniqueness check in addDataset().
Also pass transactional=False when calling associate() from
addDataset().
This is a workaround for previous commit breaking obs_subaru unit tests.
Actual problem lies deeper in transaction management in
lsst.obs.base.ingest module, that will have to be fixed later, see
discussion on (DM-16160)