Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-16160: Restore pre-insert uniqueness check in addDataset(). #98

Merged
merged 2 commits into from
Oct 17, 2018
Merged

DM-16160: Restore pre-insert uniqueness check in addDataset(). #98

merged 2 commits into from
Oct 17, 2018

Commits on Oct 12, 2018

  1. Re-apply commit 7f85ed5: "Implement constraint check in associate met… 

    …hod" (DM-16160)

Fix will be needed for this commit, in its current for it breaks
obs_subaru unit test.

Current schema lacks actual constraints for collections, this commit
adds code to verify that added rows do not violate constraints. It can
only work reliably in single-user environment, we have to move
constraints to schema definition for more reliable validation.
    @andy-slac
    andy-slac committed Oct 12, 2018
    Configuration menu
    Copy the full SHA
    7591622 View commit details
    Browse the repository at this point in the history

  2. Restore pre-insert uniqueness check in addDataset(). 

    Also pass transactional=False when calling associate() from
addDataset().

This is a workaround for previous commit breaking obs_subaru unit tests.
Actual problem lies deeper in transaction management in
lsst.obs.base.ingest module, that will have to be fixed later, see
discussion on (DM-16160)
    @andy-slac
    andy-slac committed Oct 12, 2018
    Configuration menu
    Copy the full SHA
    0ee1894 View commit details
    Browse the repository at this point in the history