DM-43429: Use real exception handling for all RemoteButler tests #980
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DimensionNameError is now a subclass of ButlerUserError so that it can be sent from server to client. It now also subclasses KeyError to replace a case in DataCoordinate.standardize where we were throwing KeyError with the same meaning as this exception.
Previously the RemoteButler registry tests relied on exceptions bubbling up from the server to a client in a way that wouldn't work in a real deployment. Now that an exception propagation framework is in place for all of the DirectButler code called by the server, we can remove this hack.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #980 +/- ##
=======================================
Coverage 88.91% 88.92%
=======================================
Files 329 329
Lines 42330 42331 +1
Branches 8703 8702 -1
=======================================
+ Hits 37639 37642 +3
+ Misses 3441 3439 -2
Partials 1250 1250 ☔ View full report in Codecov by Sentry. |
timj
approved these changes
Mar 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
doc/changesconfigs/old_dimensions