Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-43429: Use real exception handling for all RemoteButler tests #980

Merged
merged 3 commits into from
Mar 22, 2024
Merged

DM-43429: Use real exception handling for all RemoteButler tests #980

merged 3 commits into from
Mar 22, 2024

Commits on Mar 21, 2024

  1. Add exception type for calibration lookup failure

    @dhirving
    dhirving committed Mar 21, 2024
    Configuration menu
    Copy the full SHA
    eab92ff View commit details
    Browse the repository at this point in the history

  2. Make DimensionNameError propagatable 

    DimensionNameError is now a subclass of ButlerUserError so that it can be sent from server to client.  It now also subclasses KeyError to replace a  case in DataCoordinate.standardize where we were throwing KeyError with the same meaning as this exception.
    @dhirving
    dhirving committed Mar 21, 2024
    Configuration menu
    Copy the full SHA
    4abf350 View commit details
    Browse the repository at this point in the history

  3. Use real exception handling for RemoteButler test 

    Previously the RemoteButler registry tests relied on exceptions bubbling up from the server to a client in a way that wouldn't work in a real deployment.  Now that an exception propagation framework is in place for all of the DirectButler code called by the server, we can remove this hack.
    @dhirving
    dhirving committed Mar 21, 2024
    Configuration menu
    Copy the full SHA
    9bf43c0 View commit details
    Browse the repository at this point in the history