DM-43499: Add timespan to Butler.get #982
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's now more obvious that the exposure timespan is within the calibration validity range and not covering the entire validity range (which is not something that happens with real data).
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #982 +/- ##
=======================================
Coverage 88.92% 88.92%
=======================================
Files 329 329
Lines 42331 42349 +18
Branches 8702 8704 +2
=======================================
+ Hits 37642 37660 +18
Misses 3439 3439
Partials 1250 1250 ☔ View full report in Codecov by Sentry. |
This allows a call to get() to pass in an explicit timespan instead of needing to include a temporal dimension in the dataId.
timj
force-pushed
the
tickets/DM-43499
branch
2 times, most recently
from
61dc3ca
to
418d057
Compare
timj
commented
Mar 25, 2024
The older versions were triggering warnings.
v2 will stop working at the end of 2024.
TallJimbo
approved these changes
Mar 27, 2024
|
You didn't add the new parameter to the public |
|
I put a fix on #979. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
doc/changesconfigs/old_dimensions